Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2443603002: Revert of Further refine div output when a div receives focus (Closed)

Created:
4 years, 2 months ago by Mathieu
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Further refine div output when a div receives focus (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2433823003/ ) Reason for revert: Speculative revert to fix failing bots https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28199 Original issue's description: > Further refine div output when a div receives focus > > This cl makes div output the same way as classic: > - when a div receives either ChromeVox or page focus, read its text content or its aria label > - this cleans up output and retains the previously hardened behavior in Classic. > > TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience. > BUG=619279 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65 > Cr-Commit-Position: refs/heads/master@{#426497} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619279 Committed: https://crrev.com/ac37777c7afe66308015d5c1461a519d91ff7735 Cr-Commit-Position: refs/heads/master@{#426799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 4 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Mathieu
Created Revert of Further refine div output when a div receives focus
4 years, 2 months ago (2016-10-21 15:46:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443603002/1
4 years, 2 months ago (2016-10-21 15:46:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:48:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac37777c7afe66308015d5c1461a519d91ff7735 Cr-Commit-Position: refs/heads/master@{#426799}
4 years, 2 months ago (2016-10-21 16:04:44 UTC) #7
David Tseng
This isn't the cause. On Fri, Oct 21, 2016 at 9:04 AM commit-bot@chromium.org via chromiumcodereview-hr.appspot.com ...
4 years, 2 months ago (2016-10-21 16:13:53 UTC) #8
Mathieu
4 years, 2 months ago (2016-10-21 16:41:23 UTC) #9
Message was sent while issue was closed.
Hi David, please help us find the cause and let me know if I can help with
a revert.

https://bugs.chromium.org/p/chromium/issues/detail?id=658266

On Fri, Oct 21, 2016 at 12:13 PM, David Tseng <dtseng@chromium.org> wrote:

> This isn't the cause.
>
> On Fri, Oct 21, 2016 at 9:04 AM commit-bot@chromium.org via
> chromiumcodereview-hr.appspot.com <reply@chromiumcodereview-hr.
> appspotmail.com> wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/ac37777c7afe66308015d5c1461a519d91ff7735
>> Cr-Commit-Position: refs/heads/master@{#426799}
>>
>> https://codereview.chromium.org/2443603002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698