Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2443473002:
ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| (Closed)
|
Created:
4 years, 2 months ago by mcasas Modified:
4 years, 1 month ago Reviewers:
Reilly Grant (use Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_|
This CL avoids preincrementing a potentially invalidated iterator
after it has been erase()d from |photo_request_queue_|. It caused
the crash detailed in the bug.
BUG=655522
TEST= see bug, I could repro in a Linux dev debug build.
Committed: https://crrev.com/6a76be1ce16df264f18a66359177f91f2959fe77
Cr-Commit-Position: refs/heads/master@{#426728}
Patch Set 1 : #Patch Set 2 : alternative implementation suggested by reillyg@ #Messages
Total messages: 23 (13 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ImageCapture: fix using invalidated iterator when removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. ========== to ========== ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. ==========
mcasas@chromium.org changed reviewers: + reillyg@chromium.org
reillyg@ PTAL (micro fix).
The CQ bit was unchecked by mcasas@chromium.org
ptal at PS2
lgtm
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. ========== to ========== ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. ========== to ========== ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG=655522 TEST= see bug, I could repro in a Linux dev debug build. Committed: https://crrev.com/6a76be1ce16df264f18a66359177f91f2959fe77 Cr-Commit-Position: refs/heads/master@{#426728} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6a76be1ce16df264f18a66359177f91f2959fe77 Cr-Commit-Position: refs/heads/master@{#426728} |
