Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2443283002: Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD. (Closed)

Created:
4 years, 1 month ago by ericrk
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ericrk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2442963002/ ) Reason for revert: Looks like the tests use --force-gpu-rasterization, which overrides the blacklist. I think we still need this suppression. See: https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/2567 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28ATI%29/builds/6394 Original issue's description: > Remove GpuRasterization.BlueBox suppression for Win/AMD. > > GPU rasterization has been disabled on this configuration. > > BUG=653538 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=zmo@chromium.org > > Committed: https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df > Cr-Commit-Position: refs/heads/master@{#426972} TBR=zmo@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653538 Committed: https://crrev.com/02503a0d49c9335c434730dc77e2d38c620f2310 Cr-Commit-Position: refs/heads/master@{#427149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ericrk
Created Revert of Remove GpuRasterization.BlueBox suppression for Win/AMD.
4 years, 1 month ago (2016-10-24 17:50:08 UTC) #1
Ken Russell (switch to Gerrit)
Oops. Thanks for catching this. LGTM
4 years, 1 month ago (2016-10-24 18:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443283002/1
4 years, 1 month ago (2016-10-24 18:30:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 21:06:16 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 21:09:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02503a0d49c9335c434730dc77e2d38c620f2310
Cr-Commit-Position: refs/heads/master@{#427149}

Powered by Google App Engine
This is Rietveld 408576698