Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4456)

Unified Diff: chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 2442953002: Remove stl_util's deletion function use from chrome/. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/diagnostics/sqlite_diagnostics.cc ('k') | chrome/browser/intranet_redirect_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/ie_importer_browsertest_win.cc
diff --git a/chrome/browser/importer/ie_importer_browsertest_win.cc b/chrome/browser/importer/ie_importer_browsertest_win.cc
index eb52807f503ce4c9fc3d243a15d2538971abfbf3..ed2202f3f9a82803437ad6a32155626a1fc6bc8f 100644
--- a/chrome/browser/importer/ie_importer_browsertest_win.cc
+++ b/chrome/browser/importer/ie_importer_browsertest_win.cc
@@ -21,9 +21,9 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
-#include "base/stl_util.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -318,14 +318,6 @@ class TestObserver : public ProfileWriter,
}
}
- virtual void AddKeyword(std::vector<TemplateURL*> template_url,
- int default_keyword_index) {
- // TODO(jcampan): bug 1169230: we should test keyword importing for IE.
- // In order to do that we'll probably need to mock the Windows registry.
- NOTREACHED();
- base::STLDeleteContainerPointers(template_url.begin(), template_url.end());
- }
-
void AddFavicons(const favicon_base::FaviconUsageDataList& usage) override {
// Importer should group the favicon information for each favicon URL.
for (size_t i = 0; i < arraysize(kIEFaviconGroup); ++i) {
« no previous file with comments | « chrome/browser/diagnostics/sqlite_diagnostics.cc ('k') | chrome/browser/intranet_redirect_detector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698