Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 2442733002: Request new layout test baseline for V8 change (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
Clemens Hammacher, kozy
CC:
chromium-reviews, blink-reviews, jgruber
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Request new layout test baseline for V8 change Was rebaselined while https://chromiumcodereview.appspot.com/2423153002 landed in V8, which changed the line numbers again. BUG=656622, 652939, v8:5510 TBR=clemensh@chromium.org, kozyatinskiy@chromium.org NOTRY=true Committed: https://crrev.com/194a578e9c943b3f203fbc008d639a260b90e87c Cr-Commit-Position: refs/heads/master@{#426774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Achenbach
TBR
4 years, 2 months ago (2016-10-21 12:16:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442733002/1
4 years, 2 months ago (2016-10-21 12:16:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 12:28:10 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/194a578e9c943b3f203fbc008d639a260b90e87c
Cr-Commit-Position: refs/heads/master@{#426774}

Powered by Google App Engine
This is Rietveld 408576698