Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2442663005: Revert of Fix loading page using hint tables. (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Fix loading page using hint tables. (patchset #5 id:80001 of https://codereview.chromium.org/2437773003/ ) Reason for revert: CPDF_DataAvail::IsPageAvail is causing crashes. BUG=chromium:658168, chromium:658170 Original issue's description: > Fix loading page using hint tables. > > When linearized document have hint table, > The FPDFAvail_IsPageAvail return true, but > FPDF_LoadPage return nullptr, for non first pages. > > This happens, bacause document not use hint tables, to load page. > > To fix this, I force save the page's ObjNum in document. > > R=npm, dsinclair > > Committed: https://pdfium.googlesource.com/pdfium/+/ef38283688c1ee7c08bcf4204cfb78e09c039782 TBR=dsinclair@chromium.org,tsepez@chromium.org,thestig@chromium.org,art-snake@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/fd5ae3f7cf077d00af0ce3082376f4051c499c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -56 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 1 chunk +1 line, -3 lines 0 comments Download
D core/fpdfapi/parser/cpdf_document_unittest.cpp View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
npm
Created Revert of Fix loading page using hint tables.
4 years, 2 months ago (2016-10-21 16:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442663005/1
4 years, 2 months ago (2016-10-21 16:42:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/fd5ae3f7cf077d00af0ce3082376f4051c499c5d
4 years, 2 months ago (2016-10-21 16:42:37 UTC) #5
Lei Zhang
4 years, 2 months ago (2016-10-21 17:14:19 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698