Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2442543002: DevTools: New snippet button and icon (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: New snippet button and icon BUG=657982 Committed: https://crrev.com/9f279cdef07d7a89a55a6a5d8c8eea225e4adbed Cr-Commit-Position: refs/heads/master@{#426644}

Patch Set 1 #

Patch Set 2 : Undo security stuff #

Total comments: 6

Patch Set 3 : Split css into navigatorView.css and navigatorTree.css #

Total comments: 4

Patch Set 4 : space in css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -144 lines) Patch
M third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 2 chunks +38 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ResourceType.js View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css View 1 2 1 chunk +6 lines, -114 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
einbinder
ptal http://i.imgur.com/dmOVc7F.png
4 years, 2 months ago (2016-10-20 19:32:30 UTC) #2
dgozman
https://codereview.chromium.org/2442543002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js (right): https://codereview.chromium.org/2442543002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js#newcode39 third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:39: this.registerRequiredCSS("sources/navigatorView.css"); Let's have two separate css files. https://codereview.chromium.org/2442543002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js#newcode42 third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:42: ...
4 years, 2 months ago (2016-10-20 20:19:27 UTC) #3
einbinder
ptal https://codereview.chromium.org/2442543002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js (right): https://codereview.chromium.org/2442543002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js#newcode39 third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:39: this.registerRequiredCSS("sources/navigatorView.css"); On 2016/10/20 at 20:19:27, dgozman wrote: > ...
4 years, 2 months ago (2016-10-20 20:56:13 UTC) #5
dgozman
lgtm https://codereview.chromium.org/2442543002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js (right): https://codereview.chromium.org/2442543002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js#newcode39 third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:39: this.registerRequiredCSS("sources/navigatorView.css"); Let's move this after VBox.call(this). https://codereview.chromium.org/2442543002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css File ...
4 years, 2 months ago (2016-10-20 21:23:10 UTC) #6
einbinder
https://codereview.chromium.org/2442543002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js (right): https://codereview.chromium.org/2442543002/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js#newcode39 third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:39: this.registerRequiredCSS("sources/navigatorView.css"); On 2016/10/20 at 21:23:10, dgozman wrote: > Let's ...
4 years, 2 months ago (2016-10-20 21:35:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442543002/60001
4 years, 2 months ago (2016-10-20 21:36:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-20 23:24:44 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:28 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9f279cdef07d7a89a55a6a5d8c8eea225e4adbed
Cr-Commit-Position: refs/heads/master@{#426644}

Powered by Google App Engine
This is Rietveld 408576698