Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2442523003: Revert of [ic] Support data handlers that represent simple field stores. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ic] Support data handlers that represent simple field stores. (patchset #2 id:40001 of https://codereview.chromium.org/2438553003/ ) Reason for revert: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9306 "V8 Mac GC Stress" Original issue's description: > [ic] Support data handlers that represent simple field stores. > > BUG= > > Review-Url: https://codereview.chromium.org/2438553003 > Cr-Commit-Position: refs/heads/master@{#40503} TBR=jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/80f163ce34debfe385ec9885aae1c1718f018859 Cr-Commit-Position: refs/heads/master@{#40512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -276 lines) Patch
M src/code-stub-assembler.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/code-stub-assembler.cc View 4 chunks +6 lines, -124 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/handler-configuration.h View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ic/handler-configuration-inl.h View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ic/ic.cc View 6 chunks +19 lines, -61 lines 0 comments Download
M src/lookup.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/type-feedback-vector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
Created Revert of [ic] Support data handlers that represent simple field stores.
4 years, 2 months ago (2016-10-21 17:53:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442523003/1
4 years, 2 months ago (2016-10-21 17:54:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 17:54:16 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80f163ce34debfe385ec9885aae1c1718f018859
Cr-Commit-Position: refs/heads/master@{#40512}

Powered by Google App Engine
This is Rietveld 408576698