[v8] Mark layout test for rebase after enabling Ignition.

[v8] Mark layout test for rebase after enabling Ignition.

Enabling Ignition on a subset of language features requires a rebaseline
of two Blink layout tests after V8 has rolled and Ignition is enabled.

R=jochen@chromium.org
BUG=chromium:657831, chromium:588103
Committed: https://crrev.com/812d47a3a152f6c74040ca9a7121a48ad61a1507
Cr-Commit-Position: refs/heads/master@{#426775}

[Michael Starzinger, 2016-10-20 14:22:58]

mstarzinger@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Starzinger, 2016-10-20 14:22:58]

Jochen: PTAL.
Michael: FYI.

This is the observed and expected difference we see on the V8 bots:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_6...

[Michael Achenbach, 2016-10-20 14:26:17]

lgtm with comment:

https://codereview.chromium.org/2442433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2442433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:1319: crbug.com/588103
fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html [ Pass Failure
]
I'm not understanding right now why we're seeing this when there was a pass/fail
expectation. Any idea?

Usually if we add new baselines and remove expectation lines, we add the old
ones back later. Maybe add a todo and/or also just comment out this line?

[Michael Starzinger, 2016-10-20 14:40:26]

Addressed comment.

https://codereview.chromium.org/2442433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2442433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:1319: crbug.com/588103
fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html [ Pass Failure
]
On 2016/10/20 14:26:17, machenbach (slow) wrote:
> I'm not understanding right now why we're seeing this when there was a
pass/fail
> expectation. Any idea?

Nope, no idea. Not familiar enough with how V8's Blink bots work.
 
> Usually if we add new baselines and remove expectation lines, we add the old
> ones back later. Maybe add a todo and/or also just comment out this line?

Done.

[jochen (gone - plz use gerrit), 2016-10-20 17:32:38]

lgtm

[Michael Achenbach, 2016-10-20 19:24:30]

https://codereview.chromium.org/2442433002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2442433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:299: #crbug.com/588103
fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html [ Pass Failure
]
Is your chromium revision maybe outdated? This line doesn't exist in HEAD:
https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/WebKit/Layo...

At the time the bot ran it also wasn't in (which explains why it could fail):
https://chromium.googlesource.com/chromium/src/+/9f514f47362c2e82bccd7460c2/t...

This expectation landed several month ago:
https://codereview.chromium.org/1710353002 and was removed here:
https://codereview.chromium.org/2384573002/diff/1/third_party/WebKit/LayoutTe...

In which case you could just drop the commented stuff.

[Michael Starzinger, 2016-10-21 11:27:17]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/2442433002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2442433002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:299: #crbug.com/588103
fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html [ Pass Failure
]
On 2016/10/20 19:24:30, machenbach (slow) wrote:
> Is your chromium revision maybe outdated? This line doesn't exist in HEAD:
>
https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/WebKit/Layo...
> 
> At the time the bot ran it also wasn't in (which explains why it could fail):
>
https://chromium.googlesource.com/chromium/src/+/9f514f47362c2e82bccd7460c2/t...
> 
> This expectation landed several month ago:
> https://codereview.chromium.org/1710353002 and was removed here:
>
https://codereview.chromium.org/2384573002/diff/1/third_party/WebKit/LayoutTe...
> 
> In which case you could just drop the commented stuff.

Done. Yes, you are absolutely right, that's what happens when you have two
checkouts and get confused. Thanks! :)

[Michael Starzinger, 2016-10-21 11:27:40]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-10-21 11:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2442433002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-10-21 11:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 12:31:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:28:57]

Description was changed from

==========
[v8] Mark layout test for rebase after enabling Ignition.

Enabling Ignition on a subset of language features requires a rebaseline
of two Blink layout tests after V8 has rolled and Ignition is enabled.

R=jochen@chromium.org
BUG=chromium:657831,chromium:588103
==========

to

==========
[v8] Mark layout test for rebase after enabling Ignition.

Enabling Ignition on a subset of language features requires a rebaseline
of two Blink layout tests after V8 has rolled and Ignition is enabled.

R=jochen@chromium.org
BUG=chromium:657831,chromium:588103

Committed: https://crrev.com/812d47a3a152f6c74040ca9a7121a48ad61a1507
Cr-Commit-Position: refs/heads/master@{#426775}
==========

[commit-bot: I haz the power, 2016-10-21 13:28:58]

Patchset 3 (id:??) landed as
https://crrev.com/812d47a3a152f6c74040ca9a7121a48ad61a1507
Cr-Commit-Position: refs/heads/master@{#426775}