Fix initialization of offscreen resources for command buffer.

Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a1fc3eb5ba1ec2502b0efc88f0a38c8fe35e6cb1
Cr-Commit-Position: refs/heads/master@{#426949}

[erikchen, 2016-10-21 20:48:42]

Description was changed from

==========
Fix initialization of cached state in ContextState.

The previous code assumed that glColorMask has already been set to GL_TRUE x 4.
This is not necessarily the case.

BUG=657912
==========

to

==========
Fix initialization of cached state in ContextState.

The previous code assumed that glColorMask has already been set to GL_TRUE x 4.
This is not necessarily the case.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-10-21 20:48:55]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 20:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-10-21 20:49:42]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-10-21 20:49:42]

piman: Please review.

[commit-bot: I haz the power, 2016-10-21 21:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:38:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-10-21 21:58:00]

Can we move state_.InitState(NULL); to before the offscreen framebuffer
initialization instead, in GLES2DecoderImpl? That's what sets the color mask to
the default value (GL_TRUE x 4).

[erikchen, 2016-10-21 22:53:50]

piman: How does this look?

[piman, 2016-10-21 23:04:54]

That works for me, LGTM.

[erikchen, 2016-10-21 23:08:29]

Description was changed from

==========
Fix initialization of cached state in ContextState.

The previous code assumed that glColorMask has already been set to GL_TRUE x 4.
This is not necessarily the case.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-10-21 23:08:38]

Description was changed from

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-10-21 23:08:45]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:09:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:55:30]

Description was changed from

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-22 01:55:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-22 01:57:19]

Description was changed from

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix initialization of offscreen resources for command buffer.

GL default state must be set before the offscreen resources are created.

BUG=657912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a1fc3eb5ba1ec2502b0efc88f0a38c8fe35e6cb1
Cr-Commit-Position: refs/heads/master@{#426949}
==========

[commit-bot: I haz the power, 2016-10-22 01:57:20]

Patchset 2 (id:??) landed as
https://crrev.com/a1fc3eb5ba1ec2502b0efc88f0a38c8fe35e6cb1
Cr-Commit-Position: refs/heads/master@{#426949}