Plumb preferred raster bounds rather than scale

Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to
floating-point, conflation of width/height due to not preserving
aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/a1caccf274a8013424414b3b306c3c7a4f7d4d42
Cr-Commit-Position: refs/heads/master@{#426719}

[chrishtr, 2016-10-20 22:31:38]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-10-20 22:31:39]

Description was changed from

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[chrishtr, 2016-10-20 22:33:55]

Description was changed from

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the intrinsic
object, such a images, without rounding error due to floating-point, conflation
of
width/height due to not preserving aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[chrishtr, 2016-10-20 22:35:12]

chrishtr@chromium.org changed reviewers:
+ vmpstr@chromium.org

[chrishtr, 2016-10-20 22:35:18]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-10-20 23:10:26]

lgtm, can you format the description to 72 chars

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer.h#newcode487
cc/layers/layer.h:487: bool has_preferred_raster_bounds() {
Can you make this const please?

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:451: bool has_preferred_raster_bounds() { return
has_preferred_raster_bounds_; }
Can you make this const please? (I noticed this one when working on the patch to
use the scale, but might as well do it here).

[chrishtr, 2016-10-20 23:16:01]

Description was changed from

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the intrinsic
object, such a images, without rounding error due to floating-point, conflation
of
width/height due to not preserving aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to floating-point,
conflation of width/height due to not preserving aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[chrishtr, 2016-10-20 23:16:11]

Description was changed from

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to floating-point,
conflation of width/height due to not preserving aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to
floating-point, conflation of width/height due to not preserving
aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[chrishtr, 2016-10-20 23:18:25]

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer.h#newcode487
cc/layers/layer.h:487: bool has_preferred_raster_bounds() {
On 2016/10/20 at 23:10:26, vmpstr wrote:
> Can you make this const please?

Done.

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2441853002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:451: bool has_preferred_raster_bounds() { return
has_preferred_raster_bounds_; }
On 2016/10/20 at 23:10:26, vmpstr wrote:
> Can you make this const please? (I noticed this one when working on the patch
to use the scale, but might as well do it here).

Done.

[chrishtr, 2016-10-20 23:18:27]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-20 23:18:28]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2441853002/#ps20001
(title: "none")

[commit-bot: I haz the power, 2016-10-20 23:19:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-10-20 23:21:59]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-10-20 23:23:26]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-20 23:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2441853002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-10-20 23:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:48:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:27:12]

Description was changed from

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to
floating-point, conflation of width/height due to not preserving
aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Plumb preferred raster bounds rather than scale

This allows us to specify exactly the preferred raster size of the
intrinsic object, such a images, without rounding error due to
floating-point, conflation of width/height due to not preserving
aspect ratio, etc.

BUG=657431
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/a1caccf274a8013424414b3b306c3c7a4f7d4d42
Cr-Commit-Position: refs/heads/master@{#426719}
==========

[commit-bot: I haz the power, 2016-10-21 13:27:14]

Patchset 3 (id:??) landed as
https://crrev.com/a1caccf274a8013424414b3b306c3c7a4f7d4d42
Cr-Commit-Position: refs/heads/master@{#426719}