Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 2441843003: Remove fullscreen and mouselock content settings UI. (Closed)
Patch Set: Moved fullscreen / mouselock check earlier. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/content_settings_exceptions_area.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 024b1fe9ea9e9b6693f6b7ef1b8d4daf4700f4e9..5c34bace436dd6d4ed96e1d8ea5cd1ba28e940f5 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -432,14 +432,6 @@ void ContentSettingsHandler::GetLocalizedValues(
{"notificationsAllow", IDS_NOTIFICATIONS_ALLOW_RADIO},
{"notificationsAsk", IDS_NOTIFICATIONS_ASK_RADIO},
{"notificationsBlock", IDS_NOTIFICATIONS_BLOCK_RADIO},
- // Fullscreen filter.
- {"fullscreenTabLabel", IDS_FULLSCREEN_TAB_LABEL},
- {"fullscreenHeader", IDS_FULLSCREEN_HEADER},
- {"fullscreenDeprecated", IDS_EXCLUSIVE_ACCESS_DEPRECATED},
- // Mouse Lock filter.
- {"mouselockTabLabel", IDS_MOUSE_LOCK_TAB_LABEL},
- {"mouselockHeader", IDS_MOUSE_LOCK_HEADER},
- {"mouselockDeprecated", IDS_EXCLUSIVE_ACCESS_DEPRECATED},
#if defined(OS_CHROMEOS) || defined(OS_WIN)
// Protected Content filter
{"protectedContentTabLabel", IDS_PROTECTED_CONTENT_TAB_LABEL},
@@ -558,10 +550,6 @@ void ContentSettingsHandler::GetLocalizedValues(
IDS_GEOLOCATION_TAB_LABEL);
RegisterTitle(localized_strings, "notifications",
IDS_NOTIFICATIONS_TAB_LABEL);
- RegisterTitle(localized_strings, "fullscreen",
- IDS_FULLSCREEN_TAB_LABEL);
- RegisterTitle(localized_strings, "mouselock",
- IDS_MOUSE_LOCK_TAB_LABEL);
#if defined(OS_CHROMEOS)
RegisterTitle(localized_strings, "protectedContent",
IDS_PROTECTED_CONTENT_TAB_LABEL);
@@ -1108,6 +1096,14 @@ void ContentSettingsHandler::UpdateZoomLevelsExceptionsView() {
void ContentSettingsHandler::UpdateExceptionsViewFromHostContentSettingsMap(
ContentSettingsType type) {
+ // Fullscreen and mouse lock have no global settings to update.
+ // TODO(mgiuca): Delete this after removing these content settings entirely
+ // (https://crbug.com/591896).
+ if (type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
+ type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
+ return;
+ }
+
base::ListValue exceptions;
HostContentSettingsMap* settings_map =
HostContentSettingsMapFactory::GetForProfile(GetProfile());
@@ -1120,14 +1116,6 @@ void ContentSettingsHandler::UpdateExceptionsViewFromHostContentSettingsMap(
UpdateExceptionsViewFromOTRHostContentSettingsMap(type);
- // Fullscreen and mouse lock have no global settings to update.
- // TODO(mgiuca): Delete this after removing these content settings entirely
- // (https://crbug.com/591896).
- if (type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
- type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
- return;
- }
-
#if defined(OS_CHROMEOS)
// Also the default for protected contents is managed in another place.
if (type == CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER)
« no previous file with comments | « chrome/browser/resources/options/content_settings_exceptions_area.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698