Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2441843003: Remove fullscreen and mouselock content settings UI. (Closed)

Created:
4 years, 2 months ago by Matt Giuca
Modified:
4 years, 1 month ago
Reviewers:
dschuyler, stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen and mouselock content settings UI. This UI was vestigial since the content settings themselves had been removed and data deleted. This just cleans up non-functional UI. BUG=591896 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/66650d394e889187fd8f93c08b8bef011323aba3 Cr-Commit-Position: refs/heads/master@{#428964}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Moved fullscreen / mouselock check earlier. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -82 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 4 chunks +8 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (15 generated)
Matt Giuca
Hi Steven, Note that this is intended to land *after* both https://codereview.chromium.org/2423003002/ and https://codereview.chromium.org/2428433002/ which ...
4 years, 2 months ago (2016-10-21 05:34:33 UTC) #3
stevenjb
-> dschuyler@ who I believe has been looking at content settings most recently?
4 years, 2 months ago (2016-10-21 19:43:51 UTC) #5
dschuyler
lgtm
4 years, 2 months ago (2016-10-21 21:19:00 UTC) #6
Matt Giuca
On 2016/10/21 21:19:00, dschuyler wrote: > lgtm Thanks, but I will still need a RS ...
4 years, 1 month ago (2016-10-23 23:16:41 UTC) #7
stevenjb
RS lgtm
4 years, 1 month ago (2016-10-24 01:42:59 UTC) #10
Matt Giuca
On 2016/10/24 01:42:59, stevenjb wrote: > RS lgtm Thanks!
4 years, 1 month ago (2016-10-24 01:44:20 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2428433002 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-10-24 01:44:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441843003/20001
4 years, 1 month ago (2016-11-01 04:43:45 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/306452)
4 years, 1 month ago (2016-11-01 05:26:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441843003/40001
4 years, 1 month ago (2016-11-01 06:38:43 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 09:11:39 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 09:13:44 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66650d394e889187fd8f93c08b8bef011323aba3
Cr-Commit-Position: refs/heads/master@{#428964}

Powered by Google App Engine
This is Rietveld 408576698