Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5551)

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 2441843002: Fix <webview> subframe resource loads with PlzNavigate. (Closed)
Patch Set: fix NavigationRequest to handle blocking, and fix unit tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_protocols_unittest.cc
diff --git a/chrome/browser/extensions/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc
index 527ff7f056ddf055406766a06937d4138163aa78..be400b8777c48e4e50aba8512f73d20a2f20e765 100644
--- a/chrome/browser/extensions/extension_protocols_unittest.cc
+++ b/chrome/browser/extensions/extension_protocols_unittest.cc
@@ -16,6 +16,7 @@
#include "base/values.h"
#include "chrome/common/chrome_paths.h"
#include "content/public/browser/resource_request_info.h"
+#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/test/mock_resource_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "extensions/browser/extension_protocols.h"
@@ -230,18 +231,24 @@ TEST_F(ExtensionProtocolTest, IncognitoRequest) {
// Now do a subframe request.
{
- std::unique_ptr<net::URLRequest> request(
- resource_context_.GetRequestContext()->CreateRequest(
- extension->GetResourceURL("404.html"), net::DEFAULT_PRIORITY,
- &test_delegate_));
- StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
-
- if (cases[i].should_allow_sub_frame_load) {
- EXPECT_EQ(net::ERR_FILE_NOT_FOUND, test_delegate_.request_status())
- << cases[i].name;
- } else {
- EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status())
- << cases[i].name;
+ // With PlzNavigate, the subframe navigation requests are blocked in
+ // ExtensionNavigationThrottle which isn't added in this unit test. This
+ // is tested in an integration test in
+ // ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible.
+ if (!content::IsBrowserSideNavigationEnabled()) {
+ std::unique_ptr<net::URLRequest> request(
+ resource_context_.GetRequestContext()->CreateRequest(
+ extension->GetResourceURL("404.html"), net::DEFAULT_PRIORITY,
+ &test_delegate_));
+ StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+
+ if (cases[i].should_allow_sub_frame_load) {
+ EXPECT_EQ(net::ERR_FILE_NOT_FOUND, test_delegate_.request_status())
+ << cases[i].name;
+ } else {
+ EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status())
+ << cases[i].name;
+ }
}
}
}
@@ -356,12 +363,18 @@ TEST_F(ExtensionProtocolTest, AllowFrameRequests) {
EXPECT_EQ(net::OK, test_delegate_.request_status());
}
{
- std::unique_ptr<net::URLRequest> request(
- resource_context_.GetRequestContext()->CreateRequest(
- extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
- &test_delegate_));
- StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
- EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status());
+ // With PlzNavigate, the subframe navigation requests are blocked in
+ // ExtensionNavigationThrottle which isn't added in this unit test. This is
+ // tested in an integration test in
+ // ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible.
+ if (!content::IsBrowserSideNavigationEnabled()) {
+ std::unique_ptr<net::URLRequest> request(
+ resource_context_.GetRequestContext()->CreateRequest(
+ extension->GetResourceURL("test.dat"), net::DEFAULT_PRIORITY,
+ &test_delegate_));
+ StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+ EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, test_delegate_.request_status());
+ }
}
// And subresource types, such as media, should fail.
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698