Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2441843002: Fix <webview> subframe resource loads with PlzNavigate. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
Fady Samuel, nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix <webview> subframe resource loads with PlzNavigate. Also fix NavigationRequest not handling blocked requests. This fixes WebViewTests/WebViewTest.Shim_TestNestedSubframes/* WebViewTests/WebViewTest.Shim_TestWebViewInsideFrame/* with PlzNavigate. BUG=504347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7e588d6b310e78e90280d46ad74f6cddcdb58f09 Cr-Commit-Position: refs/heads/master@{#426819}

Patch Set 1 #

Patch Set 2 : fix NavigationRequest to handle blocking, and fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 3 chunks +31 lines, -18 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
jam
ExtensionNavigationThrottle is added for subframe navigations as well as main frame.
4 years, 2 months ago (2016-10-20 22:25:01 UTC) #4
Fady Samuel
lgtm
4 years, 2 months ago (2016-10-20 22:36:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441843002/1
4 years, 2 months ago (2016-10-20 22:38:04 UTC) #8
jam
Nasko: ptal at patchset 1-> 2
4 years, 2 months ago (2016-10-21 15:05:51 UTC) #17
nasko
LGTM
4 years, 2 months ago (2016-10-21 16:23:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441843002/20001
4 years, 2 months ago (2016-10-21 16:38:01 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 16:56:36 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:05:59 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e588d6b310e78e90280d46ad74f6cddcdb58f09
Cr-Commit-Position: refs/heads/master@{#426819}

Powered by Google App Engine
This is Rietveld 408576698