Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2441813002:
[ash-md] Prevents a crash when entering overview mode while dragging a window (Closed)
|
Created:
4 years, 2 months ago by varkha Modified:
4 years, 2 months ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ash-md] Prevents a crash when entering overview mode while dragging a window
BUG=330668
TEST=WindowSelectorTest.OverviewWhileDragging
Committed: https://crrev.com/4eb5c40330ada7b018e41894c633a392b483ba44
Cr-Commit-Position: refs/heads/master@{#426790}
Patch Set 1 #
Total comments: 2
Patch Set 2 : [ash-md] Prevents a crash when entering overview mode while dragging a window (adds test) #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
varkha@chromium.org changed reviewers: + tdanderson@chromium.org
tdanderson@, what do you think?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm with a question https://chromiumcodereview.appspot.com/2441813002/diff/1/ash/common/wm/overvi... File ash/common/wm/overview/window_selector_item.cc (right): https://chromiumcodereview.appspot.com/2441813002/diff/1/ash/common/wm/overvi... ash/common/wm/overview/window_selector_item.cc:435: if (label_window->GetParent() == transform_window_.window()->GetParent()) { For my own learning, in general must two windows in the same container have the same parent (i.e., the container itself) or is that just true of this specific situation?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Thanks, added a test for this crash. https://codereview.chromium.org/2441813002/diff/1/ash/common/wm/overview/wind... File ash/common/wm/overview/window_selector_item.cc (right): https://codereview.chromium.org/2441813002/diff/1/ash/common/wm/overview/wind... ash/common/wm/overview/window_selector_item.cc:435: if (label_window->GetParent() == transform_window_.window()->GetParent()) { On 2016/10/20 21:09:33, tdanderson wrote: > For my own learning, in general must two windows in the same container have the > same parent (i.e., the container itself) or is that just true of this specific > situation? Yes the two windows in the same container have the same parent (that container). The problem here is that one of those two windows in this case (the real window rather than the label that shows the title in overview) is reparented when ending a drag. Ending the drag also ends overview mode because the window hierarchy changes. So we get into shutdown but still assume that the title window and the real window belong to the same container when they are not. Note: while windows are dragged they get reparented to one of the top-level containers (like a docked container) to allow them to be on top of any other windows including docked or panels. At the end of the drag this is reverted.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=TBD ========== to ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=WindowSelectorTest.OverviewWhileDragging ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by varkha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2441813002/#ps40001 (title: "[ash-md] Prevents a crash when entering overview mode while dragging a window (adds test)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=WindowSelectorTest.OverviewWhileDragging ========== to ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=WindowSelectorTest.OverviewWhileDragging ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=WindowSelectorTest.OverviewWhileDragging ========== to ========== [ash-md] Prevents a crash when entering overview mode while dragging a window BUG=330668 TEST=WindowSelectorTest.OverviewWhileDragging Committed: https://crrev.com/4eb5c40330ada7b018e41894c633a392b483ba44 Cr-Commit-Position: refs/heads/master@{#426790} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4eb5c40330ada7b018e41894c633a392b483ba44 Cr-Commit-Position: refs/heads/master@{#426790} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
