Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2441753003: Fix some div by 0s in safe_math_impl.h (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix some div by 0s in safe_math_impl.h The majority of these are already upstream in base/, the remainder will need upstreaming. Also pull some upstream changes to reduce diffing. Upstream CL is https://codereview.chromium.org/2440143003/ BUG=657436 Committed: https://pdfium.googlesource.com/pdfium/+/a804fd48b71679ece1f1c2284c3c1835c9e20441

Patch Set 1 #

Patch Set 2 : Remove stray code from unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M third_party/base/numerics/safe_math_impl.h View 1 10 chunks +39 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
Regardless of what they do upstream, I think we want the div by 0 protection ...
4 years, 2 months ago (2016-10-21 18:49:14 UTC) #8
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-21 18:52:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441753003/20001
4 years, 2 months ago (2016-10-21 19:06:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 19:06:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a804fd48b71679ece1f1c2284c3c1835c9e2...

Powered by Google App Engine
This is Rietveld 408576698