Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2441743003: Add DCHECKs for thread access PermissionManager. (Closed)

Created:
4 years, 2 months ago by dougt
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECKs for thread access PermissionManager. The PermissionManager is not thread safe. Lets add some DCHECKs to let us know when there is an unsafe access. BUG=658018 R=jochen Committed: https://crrev.com/0ebc1f3b8cc7caef42f24aad8bd88fe1f9c3856e Cr-Commit-Position: refs/heads/master@{#426793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/permissions/permission_manager.cc View 9 chunks +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
dougt
Hi jochen, please take a look.
4 years, 2 months ago (2016-10-21 00:03:34 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-21 11:01:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441743003/1
4 years, 2 months ago (2016-10-21 14:59:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:09:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 15:34:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ebc1f3b8cc7caef42f24aad8bd88fe1f9c3856e
Cr-Commit-Position: refs/heads/master@{#426793}

Powered by Google App Engine
This is Rietveld 408576698