Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2441733002: [Sk4fGradient] Use infinity floats for clamp-mode extreme positions (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[Sk4fGradient] Use infinity floats for clamp-mode extreme positions In clamp mode, we use a couple of synthetic edges that are supposed to extend to +/- infinity (-inf .. P0 and Pn .. inf). Currently we use SK_ScalarMin/Max, but these can be overrun with large/malicious inputs. Use SK_ScalarInfinity/SK_ScalarNegativeInfinity instead, and tweak compute_interval_props() to handle inf values gracefully. BUG=skia:5835 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441733002 Committed: https://skia.googlesource.com/skia/+/8f457591e6a21c240fd2fca56a97281b556ce796

Patch Set 1 #

Patch Set 2 : harden infinity handling #

Patch Set 3 : comments #

Patch Set 4 : vertical case fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M src/effects/gradients/Sk4fGradientBase.cpp View 1 2 3 chunks +10 lines, -3 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
f(malita)
4 years, 2 months ago (2016-10-20 21:13:27 UTC) #5
reed1
lgtm
4 years, 2 months ago (2016-10-21 12:48:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441733002/60001
4 years, 2 months ago (2016-10-21 13:01:03 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8f457591e6a21c240fd2fca56a97281b556ce796

Powered by Google App Engine
This is Rietveld 408576698