Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2441673003: Disable a remote LTH test, we don't deserialize FakePictureLayer. (Closed)

Created:
4 years, 2 months ago by xingliu
Modified:
4 years, 2 months ago
Reviewers:
ajuma, Khushal
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable a remote LTH test, we don't deserialize FakePictureLayer. Currently for LTH remote test, we deserialize FakePictureLayer into PictureLayer, so on the compositor impl thread, FakePictureLayerImpl is not created but PictureLayerImpl, which cause downcasting failure. BUG=657871 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/143414007952491b458bbd5bb55116fbde7d2caa Cr-Commit-Position: refs/heads/master@{#426571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
xingliu
Please help take a look.
4 years, 2 months ago (2016-10-20 18:06:17 UTC) #5
ajuma
lgtm
4 years, 2 months ago (2016-10-20 18:13:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441673003/1
4 years, 2 months ago (2016-10-20 19:49:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 19:57:41 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/143414007952491b458bbd5bb55116fbde7d2caa
Cr-Commit-Position: refs/heads/master@{#426571}

Powered by Google App Engine
This is Rietveld 408576698