Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2441663002: Roll isolate go to binaries as generated by infra @ 6e664e19. (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll isolate go to binaries as generated by infra @ 6e664e19. This should bring back much faster uploading because of faster compression library, but built with 1.6 Go compiler, which seemed to have caused regression in speed in August roll @ a7ce77dd and was reverted in @ 07ac77f3 in September. There are also changes to auth library and various other stability improvements accumulated since February 2016. Hashes taken from builds of 3 builders on chromium.infra waterfall: /builders/infra-continuous-trusty-64/builds/4280 /builders/infra-continuous-win-64/builds/4127 /builders/infra-continuous-mac-10.9-64/builds/4142 R=maruel@chromium.org,djd@chromium.org BUG=653723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tandrii(chromium)
4 years, 2 months ago (2016-10-20 15:54:31 UTC) #1
M-A Ruel
lgtm
4 years, 2 months ago (2016-10-20 16:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441663002/1
4 years, 2 months ago (2016-10-20 16:14:32 UTC) #7
tandrii(chromium)
i don't like this roll any more. This is isolate run of this CL on ...
4 years, 2 months ago (2016-10-20 16:25:48 UTC) #9
tandrii(chromium)
and on the same *slave* and same builder 2 more builds: 319255 ====== Hits : ...
4 years, 2 months ago (2016-10-20 16:28:40 UTC) #10
tandrii(chromium)
on the other hand, linux_chromium_chromeos_rel_ng shows improvement: this CL : Hits : 16698 (4.96Gib) Misses ...
4 years, 2 months ago (2016-10-20 16:37:05 UTC) #11
tandrii(chromium)
i just had thought: mac builders are in Golo which has a limited pipe to ...
4 years, 2 months ago (2016-10-21 13:03:28 UTC) #12
M-A Ruel
4 years, 2 months ago (2016-10-21 13:07:52 UTC) #13
On 2016/10/21 13:03:28, tandrii(chromium) wrote:
> i just had thought: mac builders are in Golo which has a limited pipe to
outside
> Google storage servers. linux slaves are on GCE which have HUGE pipes to GS.
> Hence, linux servers should be optimized for sending more data faster, while
> Macs and Windowses (while in Golo) should perhaps invest more into
compression.
> What really would be awesome is measure how many bytes actually get uploaded
> with time vs just complete files. M-A, WDYT?

Likely but it is a very complex problem. Also, this is orthogonal to fixing the
regression.

Powered by Google App Engine
This is Rietveld 408576698