Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2441643002:
Remove stl_util's deletion function use from content/browser/service_worker. (Closed)
|
Created:
4 years, 2 months ago by Avi (use Gerrit) Modified:
4 years, 1 month ago Reviewers:
falken CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove stl_util's deletion function use from content/browser/service_worker.
BUG=555865
Committed: https://crrev.com/56bb7c72528a7b9241f41a34276adf732097d94b
Cr-Commit-Position: refs/heads/master@{#428657}
Patch Set 1 #Patch Set 2 : add a move constructor #
Total comments: 4
Messages
Total messages: 25 (19 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + falken@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, thanks. https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... File content/browser/service_worker/service_worker_job_coordinator.cc (right): https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... content/browser/service_worker/service_worker_job_coordinator.cc:25: ServiceWorkerJobCoordinator::JobQueue::JobQueue() = default; Question for future reference: Is = default vs {} just a style difference here, and is = default now the preferred style? https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... content/browser/service_worker/service_worker_job_coordinator.cc:44: // above were true. Thanks for clarifying the comment.
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... File content/browser/service_worker/service_worker_job_coordinator.cc (right): https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... content/browser/service_worker/service_worker_job_coordinator.cc:25: ServiceWorkerJobCoordinator::JobQueue::JobQueue() = default; On 2016/10/31 01:40:34, falken wrote: > Question for future reference: Is = default vs {} just a style difference here, > and is = default now the preferred style? I don't know if they're preferred. "= default" is useful for the move constructor below; the default copy constructor is implicitly deleted, and so we have to explicitly state that moving is OK, but since the default one would be OK, using "= default" for it is the best option. So while I was here I made this other one "= default" too. https://codereview.chromium.org/2441643002/diff/20001/content/browser/service... content/browser/service_worker/service_worker_job_coordinator.cc:44: // above were true. On 2016/10/31 01:40:34, falken wrote: > Thanks for clarifying the comment. Acknowledged.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove stl_util's deletion function use from content/browser/service_worker. BUG=555865 ========== to ========== Remove stl_util's deletion function use from content/browser/service_worker. BUG=555865 Committed: https://crrev.com/56bb7c72528a7b9241f41a34276adf732097d94b Cr-Commit-Position: refs/heads/master@{#428657} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/56bb7c72528a7b9241f41a34276adf732097d94b Cr-Commit-Position: refs/heads/master@{#428657} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
