Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3253)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc

Issue 2441633003: Disable AutofillPrivateApiTests on Linux as well, due to flakiness. (Closed)
Patch Set: Copy and paste error Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
index 2b95e0ec180b75c1bfa93e51c79fd8cc1aa9cc09..82a292345148ecc46c99879ca025b2a1e7a770c1 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
@@ -45,22 +45,12 @@ class AutofillPrivateApiTest : public ExtensionApiTest {
// TODO(hcarmona): Investigate converting these tests to unittests.
// TODO(crbug.com/643097) Disabled for flakiness.
-#if defined(OS_WIN)
-#define MAYBE_SaveAddress DISABLED_SaveAddress
-#else
-#define MAYBE_SaveAddress SaveAddress
-#endif // defined(OS_WIN)
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveAddress) {
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, DISABLED_SaveAddress) {
EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_;
}
// TODO(crbug.com/643097) Disabled for flakiness.
-#if defined(OS_WIN)
-#define MAYBE_GetCountryList DISABLED_GetCountryList
-#else
-#define MAYBE_GetCountryList GetCountryList
-#endif // defined(OS_WIN)
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_GetCountryList) {
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, DISABLED_GetCountryList) {
EXPECT_TRUE(RunAutofillSubtest("getCountryList")) << message_;
}
@@ -69,22 +59,12 @@ IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) {
}
// TODO(crbug.com/643097) Disabled for flakiness.
-#if defined(OS_WIN)
-#define MAYBE_SaveCreditCard DISABLED_SaveCreditCard
-#else
-#define MAYBE_SaveCreditCard SaveCreditCard
-#endif // defined(OS_WIN)
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveCreditCard) {
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, DISABLED_SaveCreditCard) {
EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_;
}
// TODO(crbug.com/643097) Disabled for flakiness.
-#if defined(OS_WIN)
-#define MAYBE_RemoveEntry DISABLED_RemoveEntry
-#else
-#define MAYBE_RemoveEntry RemoveEntry
-#endif // defined(OS_WIN)
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_RemoveEntry) {
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, DISABLED_RemoveEntry) {
EXPECT_TRUE(RunAutofillSubtest("removeEntry")) << message_;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698