[ResourceScheduler] Make throttling H2+QUIC default disabled

[ResourceScheduler] Make throttling H2+QUIC default disabled

Since we don't know for sure what the outcome will be and need to perform
field trials, default to disabled.

BUG=655585
Committed: https://crrev.com/f390a5e4ff02ee6a72b42faed7d519213d689896
Cr-Commit-Position: refs/heads/master@{#426508}

[jkarlin, 2016-10-20 14:44:17]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 14:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-20 14:45:15]

jkarlin@chromium.org changed reviewers:
+ csharrison@chromium.org

[jkarlin, 2016-10-20 14:45:16]

csharrison@ PTAL at everything, thanks!

[Charlie Harrison, 2016-10-20 14:52:48]

LGTM, if we plan on moving this trial through to Beta, could you update the
variations configs too so that bots will test the feature by default?

[jkarlin, 2016-10-20 15:19:08]

Patchset #2 (id:20001) has been deleted

[jkarlin, 2016-10-20 15:20:02]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 15:20:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-20 15:20:25]

Thanks, and thanks for the variant suggestion. I've added
fieldtrial_testing_config.json changes. PTAL.

[jkarlin, 2016-10-20 15:30:52]

jkarlin@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jkarlin, 2016-10-20 15:30:52]

asvitkine@chromium.org: Please review changes in fieldtrial_testing_config.json,
thanks!

[Charlie Harrison, 2016-10-20 15:31:42]

still lgtm

[commit-bot: I haz the power, 2016-10-20 16:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:12:25]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-10-20 16:32:00]

lgtm

[jkarlin, 2016-10-20 16:38:16]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:38:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-10-20 16:48:29]

The CQ bit was unchecked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-10-20 16:49:46]

Actually, I have further questions here.

What's the reason for enabling it by default in the code? It's usually the right
thing to do when the feature is ready to launch.

But in this case, it sounds like you're still at the experimental stage. In such
a stage, we recommend it's still off by default because there will be a class of
users who will get the client side default (e.g. first run, the variations
server is unreachable, etc). If the feature is not ready to launch, then we
shouldn't be turning it on for those edge cases of users.

[Alexei Svitkine (slow), 2016-10-20 16:54:12]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-10-20 16:54:13]

lgtm

Chatted offline and still LGTM after that.

This is actually turning it back to disabled (how it started originally before
base::Feature was added) and the plan is to experiment and enable it when it's
ready. So this CL is doing the right thing. :)

Sorry for the alarm bells!

[commit-bot: I haz the power, 2016-10-20 16:54:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-10-20 16:54:39]

On 2016/10/20 16:54:13, Alexei Svitkine (slow) wrote:
> lgtm
> 
> Chatted offline and still LGTM after that.
> 
> This is actually turning it back to disabled (how it started originally before
> base::Feature was added) and the plan is to experiment and enable it when it's
> ready. So this CL is doing the right thing. :)
> 
> Sorry for the alarm bells!

Thanks!

[commit-bot: I haz the power, 2016-10-20 16:58:49]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:19:18]

Description was changed from

==========
[ResourceScheduler] Make throttling H2+QUIC default disabled

Since we don't know for sure what the outcome will be and need to perform
field trials, default to disabled.

BUG=655585
==========

to

==========
[ResourceScheduler] Make throttling H2+QUIC default disabled

Since we don't know for sure what the outcome will be and need to perform
field trials, default to disabled.

BUG=655585

Committed: https://crrev.com/f390a5e4ff02ee6a72b42faed7d519213d689896
Cr-Commit-Position: refs/heads/master@{#426508}
==========

[commit-bot: I haz the power, 2016-10-21 13:19:19]

Patchset 2 (id:??) landed as
https://crrev.com/f390a5e4ff02ee6a72b42faed7d519213d689896
Cr-Commit-Position: refs/heads/master@{#426508}