Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2441583002: Revert of [inspector] migrate stepping related methods to debug-interface (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
kozy, dgozman, Yang
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] migrate stepping related methods to debug-interface (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/2423153002/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10808 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] migrate stepping related methods to debug-interface > > * introduced DebugInterface::PrepareStep and DebugInterface::ClearStepping method. > Inspector calls these methods only on pause and not interseted in calling this for not current break_id so we don't need to expose debug interface with break_id argument and can only check that current break_id is valid. > > BUG=chromium:652939, v8:5510 > R=yangguo@chromium.org,dgozman@chromium.org TBR=yangguo@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:652939, v8:5510 Committed: https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f Cr-Commit-Position: refs/heads/master@{#40455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -41 lines) Patch
M src/api.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/debug/debug.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/inspector/debugger-script.js View 1 chunk +37 lines, -0 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 2 chunks +5 lines, -0 lines 0 comments Download
M src/inspector/v8-debugger.cc View 3 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [inspector] migrate stepping related methods to debug-interface
4 years, 2 months ago (2016-10-20 08:31:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441583002/1
4 years, 2 months ago (2016-10-20 08:31:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 08:32:01 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f
Cr-Commit-Position: refs/heads/master@{#40455}

Powered by Google App Engine
This is Rietveld 408576698