Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2441543004: Refactor BrowserActivationWaiter as test support and move PopupBlockerBrowserTest to interactive_ui… (Closed)

Created:
4 years, 2 months ago by Qiang(Joe) Xu
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor BrowserActivationWaiter as test support and move PopupBlockerBrowserTest to interactive_uitest (1) Making BrowserActivationWaiter a common test support (2) move PopupBlockerBrowserTest to interactive_uitest as there exists one test that is relying on native widget activation. BUG=658295 TEST=utilizing the test support in PopupBlockerBrowserTest Committed: https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7 Cr-Commit-Position: refs/heads/master@{#426878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -38 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 3 chunks +2 lines, -37 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Qiang(Joe) Xu
Hi avi@, sky@, could you please take a look? Thanks!
4 years, 2 months ago (2016-10-21 17:05:40 UTC) #7
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-21 17:27:10 UTC) #8
sky
LGTM
4 years, 2 months ago (2016-10-21 20:08:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441543004/1
4 years, 2 months ago (2016-10-21 20:12:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 20:35:43 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:37:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7
Cr-Commit-Position: refs/heads/master@{#426878}

Powered by Google App Engine
This is Rietveld 408576698