Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2441523003: Remove gender specific language from src/tools (Closed)

Created:
4 years, 2 months ago by benwells
Modified:
4 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, asvitkine+watch_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gender specific language from src/tools BUG=542537 Committed: https://crrev.com/337f2010bdd1d89b11c8913e1b3d652092d59db4 Cr-Commit-Position: refs/heads/master@{#426658}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M tools/metrics/histograms/histograms.xml View 13 chunks +24 lines, -26 lines 0 comments Download
M tools/site_compare/drivers/win32/keyboard.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/chrome_tests.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tools/valgrind/locate_valgrind.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/regrind.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
benwells
isherman: histograms dpranke: the rest
4 years, 2 months ago (2016-10-20 05:31:55 UTC) #4
Dirk Pranke
lgtm. https://codereview.chromium.org/2441523003/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/2441523003/diff/1/tools/valgrind/chrome_tests.py#newcode178 tools/valgrind/chrome_tests.py:178: it. Othewise, filter out tests listed in the ...
4 years, 2 months ago (2016-10-20 05:35:50 UTC) #5
Ilya Sherman
tools/metrics lgtm
4 years, 2 months ago (2016-10-20 07:39:25 UTC) #8
benwells
https://codereview.chromium.org/2441523003/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/2441523003/diff/1/tools/valgrind/chrome_tests.py#newcode178 tools/valgrind/chrome_tests.py:178: it. Othewise, filter out tests listed in the appropriate ...
4 years, 2 months ago (2016-10-20 22:37:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441523003/20001
4 years, 2 months ago (2016-10-20 22:38:01 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 00:18:08 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/337f2010bdd1d89b11c8913e1b3d652092d59db4
Cr-Commit-Position: refs/heads/master@{#426658}

Powered by Google App Engine
This is Rietveld 408576698