Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

Issue 2441493002: Use emptyString() for String fields in SecurityOrigin (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
index b94f3b24b5f3bff6702218a0c3ad17bba1d8f91e..0864fb2effcaedb0cfae82fa01314a5861b9de23 100644
--- a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
@@ -115,8 +115,9 @@ static bool shouldTreatAsUniqueOrigin(const KURL& url) {
}
SecurityOrigin::SecurityOrigin(const KURL& url)
- : m_protocol(url.protocol().isNull() ? "" : url.protocol().lower()),
- m_host(url.host().isNull() ? "" : url.host().lower()),
+ : m_protocol(url.protocol().isNull() ? emptyString()
+ : url.protocol().lower()),
+ m_host(url.host().isNull() ? emptyString() : url.host().lower()),
m_port(url.port()),
m_effectivePort(url.port() ? url.port()
: defaultPortForProtocol(m_protocol)),
@@ -142,9 +143,9 @@ SecurityOrigin::SecurityOrigin(const KURL& url)
}
SecurityOrigin::SecurityOrigin()
- : m_protocol(""),
- m_host(""),
- m_domain(""),
+ : m_protocol(emptyString()),
+ m_host(emptyString()),
+ m_domain(emptyString()),
m_port(InvalidPort),
m_effectivePort(InvalidPort),
m_isUnique(true),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698