Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 244143002: Remove some NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED. (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dhnishi_gmail.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove some NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/extension and some cleanup. BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265336

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase and address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -333 lines) Patch
M chrome/browser/extensions/active_tab_permission_granter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 2 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_manager.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_manager.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.h View 1 4 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 1 2 chunks +26 lines, -35 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.h View 1 6 chunks +23 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 6 chunks +32 lines, -31 lines 0 comments Download
M chrome/browser/extensions/extension_warning_service.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_warning_service.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.h View 1 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.cc View 1 1 chunk +18 lines, -26 lines 0 comments Download
M chrome/browser/extensions/install_tracker.h View 1 3 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 1 3 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.h View 1 4 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 1 2 chunks +68 lines, -81 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 5 chunks +50 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
limasdf
when you have time
6 years, 8 months ago (2014-04-20 07:03:49 UTC) #1
not at google - send to devlin
lgtm. basically doing a mass grep placement for "scoped_extension_registry_observer_" to "extension_registry_observer_" would work. https://codereview.chromium.org/244143002/diff/170001/chrome/browser/extensions/extension_gcm_app_handler.h File ...
6 years, 8 months ago (2014-04-21 19:08:33 UTC) #2
limasdf
Thanks for the review! https://codereview.chromium.org/244143002/diff/170001/chrome/browser/extensions/extension_gcm_app_handler.h File chrome/browser/extensions/extension_gcm_app_handler.h (right): https://codereview.chromium.org/244143002/diff/170001/chrome/browser/extensions/extension_gcm_app_handler.h#newcode85 chrome/browser/extensions/extension_gcm_app_handler.h:85: scoped_extension_registry_observer_; On 2014/04/21 19:08:33, kalman ...
6 years, 8 months ago (2014-04-22 17:18:27 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-22 17:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/244143002/270001
6 years, 8 months ago (2014-04-22 17:25:31 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 19:50:00 UTC) #6
Message was sent while issue was closed.
Change committed as 265336

Powered by Google App Engine
This is Rietveld 408576698