Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2441033002: Reland: Further refine div output when a div receives focus (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Further refine div output when a div receives focus This cl makes div output the same way as classic: - when a div receives either ChromeVox or page focus, read its text content or its aria label - this cleans up output and retains the previously hardened behavior in Classic. TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience. BUG=619279 TBR=dtseng@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65 Cr-Commit-Position: refs/heads/master@{#426497} patch from issue 2433823003 at patchset 20001 (http://crrev.com/2433823003#ps20001) Committed: https://crrev.com/a1bc4757d76f7c9cf83962c112f1a6be24320854 Cr-Commit-Position: refs/heads/master@{#426833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 4 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441033002/1
4 years, 2 months ago (2016-10-21 17:20:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 17:39:20 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:41:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1bc4757d76f7c9cf83962c112f1a6be24320854
Cr-Commit-Position: refs/heads/master@{#426833}

Powered by Google App Engine
This is Rietveld 408576698