Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4463)

Unified Diff: chrome/browser/ui/webui/options/edit_dictionary_browsertest.js

Issue 2440973003: Revert of Disable many tests with flaky accessibility audits. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
diff --git a/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js b/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
index d1239c96e344e749347cf583ea47db77fbde6ff1..5bcb0e0b18ab6615b77c92190359e4f49d89fb1e 100644
--- a/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
+++ b/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
@@ -60,13 +60,6 @@
};
// Verify that users can add and remove words in the dictionary.
-// TODO(crbug.com/657514) Flakes on linux and chromeos too.
-GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
-GEN('#define MAYBE_testAddRemoveWords ' +
- 'DISABLED_testAddRemoveWords');
-GEN('#else');
-GEN('#define MAYBE_testAddRemoveWords testAddRemoveWords');
-GEN('#endif');
TEST_F('EditDictionaryWebUITest', 'testAddRemoveWords', function() {
var testWord = 'foo';
$('language-dictionary-overlay-word-list').querySelector('input').value =
@@ -121,14 +114,7 @@
// Verify that dictionary shows newly added words that arrived in a
// notification, but ignores duplicate add notifications.
-// TODO(crbug.com/657514) Flakes on linux and chromeos.
-GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
-GEN('#define MAYBE_testAddNotification ' +
- 'DISABLED_testAddNotification');
-GEN('#else');
-GEN('#define MAYBE_testAddNotification testAddNotification');
-GEN('#endif');
-TEST_F('EditDictionaryWebUITest', 'MAYBE_testAddNotification', function() {
+TEST_F('EditDictionaryWebUITest', 'testAddNotification', function() {
// Begin with an empty dictionary.
EditDictionaryOverlay.setWordList([]);
expectEquals(1, EditDictionaryOverlay.getWordListForTesting().items.length);
@@ -152,8 +138,7 @@
// Verify that dictionary hides newly removed words that arrived in a
// notification, but ignores duplicate remove notifications.
// TODO(crbug.com/631940): Flaky on Win 7.
-// TODO(crbug.com/657514) Flakes on linux and chromeos too.
-GEN('#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)');
+GEN('#if defined(OS_WIN)');
GEN('#define MAYBE_testRemoveNotification DISABLED_testRemoveNotification');
GEN('#else');
GEN('#define MAYBE_testRemoveNotification testRemoveNotification');

Powered by Google App Engine
This is Rietveld 408576698