Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

Issue 2440973003: Revert of Disable many tests with flaky accessibility audits. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 GEN_INCLUDE(['options_browsertest_base.js']); 5 GEN_INCLUDE(['options_browsertest_base.js']);
6 6
7 /** 7 /**
8 * TestFixture for testing messages of dictionary download progress in language 8 * TestFixture for testing messages of dictionary download progress in language
9 * options WebUI. 9 * options WebUI.
10 * @extends {testing.Test} 10 * @extends {testing.Test}
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 options.LanguageOptions.onDictionaryDownloadFailure('en-US'); 104 options.LanguageOptions.onDictionaryDownloadFailure('en-US');
105 expectTrue($('spellcheck-language-message').hidden); 105 expectTrue($('spellcheck-language-message').hidden);
106 expectTrue($('language-options-dictionary-downloading-message').hidden); 106 expectTrue($('language-options-dictionary-downloading-message').hidden);
107 expectFalse($('language-options-dictionary-download-failed-message').hidden); 107 expectFalse($('language-options-dictionary-download-failed-message').hidden);
108 expectFalse( 108 expectFalse(
109 $('language-options-dictionary-download-fail-help-message').hidden); 109 $('language-options-dictionary-download-fail-help-message').hidden);
110 }); 110 });
111 111
112 // Verify that clicking the retry button calls the handler. 112 // Verify that clicking the retry button calls the handler.
113 // This test is flaky on Windows. https://crbug.com/616791 113 // This test is flaky on Windows. https://crbug.com/616791
114 // TODO(crbug.com/657514) Flakes on linux and chromeos too. 114 GEN('#if defined(OS_WIN)');
115 GEN('#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)');
116 GEN('#define MAYBE_testdictionaryDownloadRetry ' + 115 GEN('#define MAYBE_testdictionaryDownloadRetry ' +
117 'DISABLED_testdictionaryDownloadRetry'); 116 'DISABLED_testdictionaryDownloadRetry');
118 GEN('#else'); 117 GEN('#else');
119 GEN('#define MAYBE_testdictionaryDownloadRetry testdictionaryDownloadRetry'); 118 GEN('#define MAYBE_testdictionaryDownloadRetry testdictionaryDownloadRetry');
120 GEN('#endif // defined(OS_WIN)'); 119 GEN('#endif // defined(OS_WIN)');
121 TEST_F('LanguagesOptionsDictionaryDownloadWebUITest', 120 TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',
122 'MAYBE_testdictionaryDownloadRetry', 121 'MAYBE_testdictionaryDownloadRetry',
123 function() { 122 function() {
124 this.mockHandler.expects(once()).retryDictionaryDownload('en-US'). 123 this.mockHandler.expects(once()).retryDictionaryDownload('en-US').
125 will(callFunction(function() { 124 will(callFunction(function() {
126 options.LanguageOptions.onDictionaryDownloadBegin('en-US'); 125 options.LanguageOptions.onDictionaryDownloadBegin('en-US');
127 })); 126 }));
128 options.LanguageOptions.onDictionaryDownloadFailure('en-US'); 127 options.LanguageOptions.onDictionaryDownloadFailure('en-US');
129 $('dictionary-download-retry-button').click(); 128 $('dictionary-download-retry-button').click();
130 }); 129 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698