Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2440893002: Update MediaKeySession to keep related code blocks together (Closed)

Created:
4 years, 2 months ago by jrummell
Modified:
4 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update MediaKeySession to keep related code blocks together BUG=646902 TEST=EME tests pass Committed: https://crrev.com/5deb211770d7ce7ad43f26fefb097d6f4879f6ed Cr-Commit-Position: refs/heads/master@{#426877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -159 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 3 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 11 chunks +164 lines, -152 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL. Mostly moving code out of actionTimerFired() and into methods next to where they're referenced.
4 years, 2 months ago (2016-10-21 03:54:00 UTC) #2
xhwang
I <3 this change! LGTM
4 years, 2 months ago (2016-10-21 16:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440893002/1
4 years, 2 months ago (2016-10-21 17:39:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 20:30:26 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:32:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5deb211770d7ce7ad43f26fefb097d6f4879f6ed
Cr-Commit-Position: refs/heads/master@{#426877}

Powered by Google App Engine
This is Rietveld 408576698