Cut VrShell dependency on WebUi.

Cut VrShell dependency on WebUi.

Adding the native-to-HTML-UI path caused VrShell to depend on WebUi,
which creates a circular dependency and breaks unit tests.  Fix this.

BUG=641508
Committed: https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d
Cr-Commit-Position: refs/heads/master@{#426791}

[cjgrant, 2016-10-20 21:38:01]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[mthiesse, 2016-10-20 21:43:53]

lgtm

[bshe, 2016-10-20 22:21:28]

On 2016/10/20 21:43:53, mthiesse wrote:
> lgtm

lgtm

[bshe, 2016-10-20 22:26:03]

one minor nit

https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_interface.h (right):

https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_interface.h:13: class UiCommandHandler {
nit: perhaps add delegate to name since this is essentially a delegate?

[cjgrant, 2016-10-21 13:44:39]

https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_interface.h (right):

https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_interface.h:13: class UiCommandHandler {
On 2016/10/20 22:26:03, bshe wrote:
> nit: perhaps add delegate to name since this is essentially a delegate?

Hmmm, I see this as an interface rather than delegate.  go/style says interfaces
may optionally end with an Interface suffix, but don't have to.  I'll put on the
Interface suffix for now, and we can discuss.

[cjgrant, 2016-10-21 13:58:57]

On 2016/10/21 13:44:39, cjgrant wrote:
>
https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/ui_interface.h (right):
> 
>
https://codereview.chromium.org/2440823002/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/ui_interface.h:13: class UiCommandHandler {
> On 2016/10/20 22:26:03, bshe wrote:
> > nit: perhaps add delegate to name since this is essentially a delegate?
> 
> Hmmm, I see this as an interface rather than delegate.  go/style says
interfaces
> may optionally end with an Interface suffix, but don't have to.  I'll put on
the
> Interface suffix for now, and we can discuss.

Actually, I think the code looks worse with the interface suffix.  Michael
verbally mentioned a preference for keeping the naming as is.  So I'll submit
like this, but as always, we should chat about this to get everyone aligned on
future naming.  :)

[cjgrant, 2016-10-21 13:59:09]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2016-10-21 13:59:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 14:39:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 15:03:03]

Description was changed from

==========
Cut VrShell dependency on WebUi.

Adding the native-to-HTML-UI path caused VrShell to depend on WebUi,
which creates a circular dependency and breaks unit tests.  Fix this.

BUG=641508
==========

to

==========
Cut VrShell dependency on WebUi.

Adding the native-to-HTML-UI path caused VrShell to depend on WebUi,
which creates a circular dependency and breaks unit tests.  Fix this.

BUG=641508

Committed: https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d
Cr-Commit-Position: refs/heads/master@{#426791}
==========

[commit-bot: I haz the power, 2016-10-21 15:03:06]

Patchset 1 (id:??) landed as
https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d
Cr-Commit-Position: refs/heads/master@{#426791}