Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 2440733003: Merge Fix Bookmarks Bar Drag-and-Drop between folders (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller.cc
diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc
index aa608d550c6b2ca09739a922c22983c4f7904740..29996dc50595c0d6e40e1c74da790c5840ca7d2c 100644
--- a/ui/views/controls/menu/menu_controller.cc
+++ b/ui/views/controls/menu/menu_controller.cc
@@ -532,7 +532,13 @@ void MenuController::Cancel(ExitType type) {
// WARNING: the call to MenuClosed deletes us.
return;
}
- ExitAsyncRun();
+
+ // On Windows and Linux the destruction of this menu's Widget leads to the
+ // teardown of the platform specific drag-and-drop Widget. Do not shutdown
+ // while dragging, leave the Widget hidden until drag-and-drop has completed,
+ // at which point all menus will be destroyed.
+ if (!drag_in_progress_)
+ ExitAsyncRun();
}
void MenuController::AddNestedDelegate(
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698