Merge Fix Bookmarks Bar Drag-and-Drop between folders

Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397
Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)

[jonross, 2016-10-20 19:53:46]

Description was changed from

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

to

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

[jonross, 2016-10-20 19:53:46]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-10-20 19:53:53]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:54:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:54:29]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[jonross, 2016-10-20 19:58:49]

Description was changed from

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

to

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

[jonross, 2016-10-20 19:59:04]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 20:03:31]

Description was changed from

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

to

==========
Merge Fix Bookmarks Bar Drag-and-Drop between folders
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Review-Url: https://codereview.chromium.org/2422283002
Cr-Commit-Position: refs/heads/master@{#425790}
(cherry picked from commit 24470df35ac9d98824f447d9a0112c0bdbdf1cb5)
==========

[commit-bot: I haz the power, 2016-10-20 20:03:31]

Committed patchset #1 (id:1)