Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2440693002: Revert of [heap] Start sweeper tasks after evacuation. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428043002/ ) Reason for revert: Performance regression on arm64: crbug.com/657776 Original issue's description: > [heap] Start sweeper tasks after evacuation. > > This allows us to use more tasks for parallel evacuation. > > BUG= TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4490a7601c81647a4fb93da94360f271eb172473 Cr-Commit-Position: refs/heads/master@{#40465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -54 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 4 chunks +24 lines, -10 lines 0 comments Download
M src/heap/mark-compact.cc View 12 chunks +43 lines, -34 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Created Revert of [heap] Start sweeper tasks after evacuation.
4 years, 2 months ago (2016-10-20 12:14:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440693002/1
4 years, 2 months ago (2016-10-20 12:14:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 12:15:05 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4490a7601c81647a4fb93da94360f271eb172473
Cr-Commit-Position: refs/heads/master@{#40465}

Powered by Google App Engine
This is Rietveld 408576698