Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: src/heap/remembered-set.cc

Issue 2440683002: [heap] Move typed slot filtering logic into sweeper. (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/slot-set.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/remembered-set.cc
diff --git a/src/heap/remembered-set.cc b/src/heap/remembered-set.cc
deleted file mode 100644
index 786e1950765cc9d32fa25249de7cf0b6df705905..0000000000000000000000000000000000000000
--- a/src/heap/remembered-set.cc
+++ /dev/null
@@ -1,50 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/heap/remembered-set.h"
-#include "src/heap/heap-inl.h"
-#include "src/heap/heap.h"
-#include "src/heap/mark-compact.h"
-#include "src/heap/slot-set.h"
-#include "src/heap/spaces.h"
-#include "src/heap/store-buffer.h"
-#include "src/macro-assembler.h"
-
-namespace v8 {
-namespace internal {
-
-template <PointerDirection direction>
-void RememberedSet<direction>::ClearInvalidTypedSlots(Heap* heap,
- MemoryChunk* chunk) {
- STATIC_ASSERT(direction == OLD_TO_NEW);
- DCHECK(chunk->owner()->identity() == CODE_SPACE);
- TypedSlotSet* slots = GetTypedSlotSet(chunk);
- if (slots != nullptr) {
- slots->Iterate(
- [heap, chunk](SlotType type, Address host_addr, Address addr) {
- if (Marking::IsBlack(ObjectMarking::MarkBitFrom(host_addr))) {
- return KEEP_SLOT;
- } else {
- return REMOVE_SLOT;
- }
- },
- TypedSlotSet::KEEP_EMPTY_CHUNKS);
- }
-}
-
-template <PointerDirection direction>
-bool RememberedSet<direction>::IsValidSlot(Heap* heap, MemoryChunk* chunk,
- Object** slot) {
- STATIC_ASSERT(direction == OLD_TO_NEW);
- // If the target object is not black, the source slot must be part
- // of a non-black (dead) object.
- return heap->mark_compact_collector()->IsSlotInBlackObject(
- chunk, reinterpret_cast<Address>(slot));
-}
-
-template void RememberedSet<OLD_TO_NEW>::ClearInvalidTypedSlots(
- Heap* heap, MemoryChunk* chunk);
-
-} // namespace internal
-} // namespace v8
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/slot-set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698