Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2440653002: [sql] Verify regexp not cached with prepared statement. (Closed)

Created:
4 years, 2 months ago by Scott Hess - ex-Googler
Modified:
4 years, 1 month ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Verify regexp not cached with prepared statement. When the bug was logged, SQLite had a flaw where the regular expression (Y in X REGEXP Y or REGEXP(Y,X)) effectively had the compiled results cached with the prepared statement. At some point Chromium pulled a version of SQLite which fixed this, this test verifies that the SQLite currently in use has the fix. BUG=248608 TBR=nyquist@chromium.org Committed: https://crrev.com/001ae16f0528c5d517eeea681d26a5220f96f326 Cr-Commit-Position: refs/heads/master@{#426398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M sql/sqlite_features_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Scott Hess - ex-Googler
Gonna drop this test-only change in TBR, before I forget. The bug has details of ...
4 years, 2 months ago (2016-10-20 03:27:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440653002/1
4 years, 2 months ago (2016-10-20 03:28:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 04:05:24 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/001ae16f0528c5d517eeea681d26a5220f96f326 Cr-Commit-Position: refs/heads/master@{#426398}
4 years, 2 months ago (2016-10-21 13:15:20 UTC) #9
nyquist
4 years, 1 month ago (2016-10-24 22:48:18 UTC) #10
Message was sent while issue was closed.
belated lgtm

Powered by Google App Engine
This is Rietveld 408576698