Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
Committed: https://crrev.com/820a95b0b81d33e42712f9198c215f703412e1a1
Cr-Commit-Position: refs/heads/master@{#426935}
Description was changed from ========== Remove TabModelSelector's dependency on ChromeFullscreenManager. ChromeFullscreenManager will now register and ...
4 years, 2 months ago
(2016-10-20 00:03:51 UTC)
#1
Description was changed from
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
Add an explicit initializeTabModelSelector call to ChromeActivity.
ChromeActivity's initialization path has gotten a bit unwieldly
and this attempts to bring some sanity to that.
BUG=
==========
to
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
==========
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/165782)
4 years, 2 months ago
(2016-10-21 22:01:11 UTC)
#10
Description was changed from ========== Remove TabModelSelector's dependency on ChromeFullscreenManager. ChromeFullscreenManager will now register and ...
4 years, 2 months ago
(2016-10-22 00:29:53 UTC)
#14
Message was sent while issue was closed.
Description was changed from
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
==========
to
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
==========
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago
(2016-10-22 00:29:54 UTC)
#15
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
commit-bot: I haz the power
Description was changed from ========== Remove TabModelSelector's dependency on ChromeFullscreenManager. ChromeFullscreenManager will now register and ...
4 years, 2 months ago
(2016-10-22 00:32:45 UTC)
#16
Message was sent while issue was closed.
Description was changed from
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
==========
to
==========
Remove TabModelSelector's dependency on ChromeFullscreenManager.
ChromeFullscreenManager will now register and listen
for updates internally and avoids the prior cyclical
dependency.
This also fixes a bug introduced in:
https://codereview.chromium.org/2414913004
In that, we were not clearing the reference to Tab when
reparenting and then there were two fullscreen managers
listening for updates.
BUG=656939
Committed: https://crrev.com/820a95b0b81d33e42712f9198c215f703412e1a1
Cr-Commit-Position: refs/heads/master@{#426935}
==========
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/820a95b0b81d33e42712f9198c215f703412e1a1 Cr-Commit-Position: refs/heads/master@{#426935}
4 years, 2 months ago
(2016-10-22 00:32:46 UTC)
#17
Issue 2440643002: Remove TabModelSelector's dependency on ChromeFullscreenManager.
(Closed)
Created 4 years, 2 months ago by Ted C
Modified 4 years, 2 months ago
Reviewers: Yusuf
Base URL:
Comments: 0