Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2440563002: Subtract start_coord instead of adding it (Closed)

Created:
4 years, 2 months ago by scroggo_chromium
Modified:
4 years, 2 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Subtract start_coord instead of adding it crrev.com/2420843003 (DIFFERENT ISSUE) introduced some changes in sampled images. (I already corrected the problem for interlaced PNGs in crrev.com/2424353003.) When deciding whether a row is needed, we need to subtract the starting coordinate, similar to how we subtracted fFirstRow in SkPngCodec. This should "fix" the remaining untriaged images in Gold (i.e. we will go back to producing the original image). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2440563002 Committed: https://skia.googlesource.com/skia/+/aef247af0a909f94cf9478c586cc64fabf333355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/codec/SkSampler.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo_chromium
4 years, 2 months ago (2016-10-19 19:11:54 UTC) #3
msarett
lgtm
4 years, 2 months ago (2016-10-19 19:16:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440563002/1
4 years, 2 months ago (2016-10-19 19:17:14 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 19:56:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aef247af0a909f94cf9478c586cc64fabf333355

Powered by Google App Engine
This is Rietveld 408576698