Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2439973004: Fall back from analytic to sampling earlier (Closed)

Created:
4 years, 2 months ago by liyuqian
Modified:
4 years, 2 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org, f(malita), bungeman
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fall back from analytic to sampling earlier This magically fixes some strange js unit tests in Chrome. Those tests only fail in virtual/gpu which somehow interacts with my cpu rasterizer? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2439973004 Committed: https://skia.googlesource.com/skia/+/7a86423c42433ab8a7df2b06bd954b2427217bb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/core/SkScan_AAAPath.cpp View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
liyuqian
4 years, 2 months ago (2016-10-21 16:18:31 UTC) #4
liyuqian
Please take a quick look at this small change which is blocking my Chrome layout ...
4 years, 2 months ago (2016-10-21 19:35:46 UTC) #5
reed1
lgtm
4 years, 2 months ago (2016-10-21 19:43:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439973004/1
4 years, 2 months ago (2016-10-21 20:37:19 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:38:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a86423c42433ab8a7df2b06bd954b2427217bb9

Powered by Google App Engine
This is Rietveld 408576698