Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2439953002: Revert of [V8][Metric] Initial implementation of the RuntimeStatsMetric (Closed)

Created:
4 years, 2 months ago by aiolos (Not reviewing)
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [V8][Metric] Initial implementation of the RuntimeStatsMetric (patchset #6 id:100001 of https://chromiumcodereview.appspot.com/2415963002/ ) Reason for revert: This is causing test failures on the CQ and locally. Link to bot with CQ failures: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds From a local run on linux: TypeError: tr.v.ValueSet is not a constructor at Object.testFn_ (http://127.0.0.1:8003/tracing/metrics/v8/runtime_stats_metric_test.html:179:18) at Object.run (http://127.0.0.1:8003/tracing/base/unittest/test_case.html:79:19) at Object.<anonymous> (http://127.0.0.1:8003/tracing/base/unittest/test_runner.html:218:52) at Object.runCurrentTestCase_ (http://127.0.0.1:8003/tracing/base/unittest/test_runner.html:216:14) at Object.runOneTestCase_ (http://127.0.0.1:8003/tracing/base/unittest/test_runner.html:169:12) Original issue's description: > [V8][Metric] Initial implementation of the RuntimeStatsMetric > > This CL implements a runtime stats metric that extracts the runtime > stats info from the V8ThreadSlices up to interactive time. > Then these values are grouped by 'type'. Each type is a single value > histogram. Histograms are repeated for count and duration. > > Each 'Type' histogram has a RelatedValueMap that describes the > individual runtime stats used to calculate that 'type' data. > > BUG=catapult:#2938 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/55c4800f013cba6cb2a4b77e8c49b643d56a8873 TBR=eakuefner@chromium.org,benjhayden@chromium.org,cbruni@chromium.org,lpy@chromium.org,nednguyen@google.com,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2938 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/96f25d9aa22bdc48bb9e6fa417585fb150caa0a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -554 lines) Patch
M tracing/trace_viewer.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D tracing/tracing/extras/v8/runtime_stats_entry.html View 1 chunk +0 lines, -125 lines 0 comments Download
D tracing/tracing/extras/v8/runtime_stats_entry_test.html View 1 chunk +0 lines, -119 lines 0 comments Download
M tracing/tracing/metrics/all_metrics.html View 1 chunk +0 lines, -1 line 0 comments Download
D tracing/tracing/metrics/v8/runtime_stats_metric.html View 1 chunk +0 lines, -104 lines 0 comments Download
D tracing/tracing/metrics/v8/runtime_stats_metric_test.html View 1 chunk +0 lines, -194 lines 0 comments Download
M tracing/tracing/ui/extras/v8/runtime_call_stats_table.html View 5 chunks +111 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
aiolos (Not reviewing)
Created Revert of [V8][Metric] Initial implementation of the RuntimeStatsMetric
4 years, 2 months ago (2016-10-20 22:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439953002/1
4 years, 2 months ago (2016-10-20 22:05:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/96f25d9aa22bdc48bb9e6fa417585fb150caa0a1
4 years, 2 months ago (2016-10-20 22:05:25 UTC) #5
fmeawad
4 years, 2 months ago (2016-10-20 22:15:26 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://chromiumcodereview.appspot.com/2436193002/ by fmeawad@chromium.org.

The reason for reverting is: The CL conflicted with the CL that landed right
before it
(https://github.com/catapult-project/catapult/commit/f5d3b3605c72ff72fce258c4d...)

Fixing the conflict and relanding..

Powered by Google App Engine
This is Rietveld 408576698