Make all text buttons on download shelf work well with themes, not just

Make all text buttons on download shelf work well with themes, not just
the "show all" button.

BUG=657935
Committed: https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35
Cr-Commit-Position: refs/heads/master@{#426828}

[Evan Stade, 2016-10-20 20:26:19]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[Evan Stade, 2016-10-20 20:29:35]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-10-20 20:29:36]

+sadrul for ui/views/

[msw, 2016-10-20 21:54:05]

https://codereview.chromium.org/2439873002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2439873002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_shelf_view.cc:176:
set_background(views::Background::CreateSolidBackground(bg_color));
Why would each call to ConfigureButtonForTheme change the background color of
the shelf view? Perhaps this should be done separately in
DownloadShelfView::UpdateColorsFromTheme?

[Evan Stade, 2016-10-20 23:11:02]

https://codereview.chromium.org/2439873002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2439873002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_shelf_view.cc:176:
set_background(views::Background::CreateSolidBackground(bg_color));
On 2016/10/20 21:54:05, msw wrote:
> Why would each call to ConfigureButtonForTheme change the background color of
> the shelf view? Perhaps this should be done separately in
> DownloadShelfView::UpdateColorsFromTheme?

no reason, done

[Evan Stade, 2016-10-20 23:11:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-20 23:20:38]

lgtm

[sadrul, 2016-10-21 01:03:26]

lgtm

[commit-bot: I haz the power, 2016-10-21 01:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:14:56]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-10-21 17:07:49]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:30:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 17:36:22]

Description was changed from

==========
Make all text buttons on download shelf work well with themes, not just
the "show all" button.

BUG=657935
==========

to

==========
Make all text buttons on download shelf work well with themes, not just
the "show all" button.

BUG=657935

Committed: https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35
Cr-Commit-Position: refs/heads/master@{#426828}
==========

[commit-bot: I haz the power, 2016-10-21 17:36:23]

Patchset 2 (id:??) landed as
https://crrev.com/c9ac8cf058d18afc6ab23455560da81bc2154c35
Cr-Commit-Position: refs/heads/master@{#426828}