Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2439863004: Update two chromeos system dialogs to reuse more DialogDelegateView (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update two chromeos system dialogs to reuse more DialogDelegateView functionality. Screenshots on the bug - this is so vastly better looking IMO as to not need UI review. BUG=658410, 633986 Committed: https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8 Cr-Commit-Position: refs/heads/master@{#426934}

Patch Set 1 #

Total comments: 4

Patch Set 2 : to boldly make changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -129 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc View 6 chunks +30 lines, -62 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc View 6 chunks +28 lines, -62 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Evan Stade
4 years, 2 months ago (2016-10-21 21:44:56 UTC) #3
Daniel Erat
lgtm agreed that this looks much better than the whitespace-heavy old dialogs . https://codereview.chromium.org/2439863004/diff/1/chrome/app/chromeos_strings.grdp File ...
4 years, 2 months ago (2016-10-21 22:00:39 UTC) #4
Evan Stade
https://codereview.chromium.org/2439863004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2439863004/diff/1/chrome/app/chromeos_strings.grdp#newcode5595 chrome/app/chromeos_strings.grdp:5595: This feature allows you to access quickly any signed-in ...
4 years, 2 months ago (2016-10-21 22:17:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439863004/20001
4 years, 2 months ago (2016-10-21 22:18:36 UTC) #8
Evan Stade
side note, I confirmed the string change with ainslie@
4 years, 2 months ago (2016-10-21 22:36:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-22 00:25:46 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 00:28:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8
Cr-Commit-Position: refs/heads/master@{#426934}

Powered by Google App Engine
This is Rietveld 408576698