Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2439833002: Expose RTT and throughput estimates from Cronet (Closed)

Created:
4 years, 2 months ago by tbansal1
Modified:
4 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, agrieve+watch_chromium.org, mgersh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose RTT and throughput estimates from Cronet The estimates are computed by the network quality estimator (NQE) and are pushed to CronetUrlRequestContext. Embedders can query for the estimates by calling appropriate methods on CronetEngine. This CL is a reland of https://codereview.chromium.org/2417643007/. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG=654498 Committed: https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3 Cr-Commit-Position: refs/heads/master@{#426614}

Patch Set 1 : Patch committted in last CL (https://codereview.chromium.org/2417643007/) #

Patch Set 2 : Fix 64 bit compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -10 lines) Patch
M components/cronet/android/BUILD.gn View 4 chunks +12 lines, -1 line 0 comments Download
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +36 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java View 1 chunk +15 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 3 chunks +21 lines, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 4 chunks +63 lines, -3 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 4 chunks +20 lines, -1 line 0 comments Download
M net/nqe/network_quality.h View 1 chunk +13 lines, -1 line 0 comments Download
M net/nqe/network_quality.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (21 generated)
tbansal1
xunjieli: PTAL at diff of PS2 and PS1. Thanks.
4 years, 2 months ago (2016-10-20 20:33:52 UTC) #11
tbansal1
4 years, 2 months ago (2016-10-20 20:34:13 UTC) #12
tbansal1
I have verified the fix by locally building arm64 version of Cronet.
4 years, 2 months ago (2016-10-20 20:37:30 UTC) #16
xunjieli
lgtm
4 years, 2 months ago (2016-10-20 20:37:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439833002/40001
4 years, 2 months ago (2016-10-20 21:53:22 UTC) #24
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 2 months ago (2016-10-20 21:53:23 UTC) #25
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 2 months ago (2016-10-20 22:02:10 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-20 22:06:49 UTC) #28
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:23 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3
Cr-Commit-Position: refs/heads/master@{#426614}

Powered by Google App Engine
This is Rietveld 408576698