Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2439813002: media: Move pipeline_statistics_struct_traits.h (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Move pipeline_statistics_struct_traits.h This file is only used by the typemap located in media/mojo/interfaces. Move it there to be closer to where it's used. This is also consistent with how other *struct_traits.h files are organized. BUG=611224 Committed: https://crrev.com/5476624b8b351bfc350ee29ea10a81ad53879134 Cr-Commit-Position: refs/heads/master@{#426579}

Patch Set 1 #

Patch Set 2 : media: Move pipeline_statistics_struct_traits.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -53 lines) Patch
D media/mojo/common/pipeline_statistics_struct_traits.h View 1 chunk +0 lines, -49 lines 0 comments Download
M media/mojo/interfaces/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/interfaces/pipeline_statistics.typemap View 1 chunk +2 lines, -1 line 0 comments Download
A + media/mojo/interfaces/pipeline_statistics_struct_traits.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xhwang
Only moving a file... I found it a bit odd that we have a .h ...
4 years, 2 months ago (2016-10-20 17:10:09 UTC) #2
dcheng
mojo rs lgtm, assuming it looks fine to other media OWNERS
4 years, 2 months ago (2016-10-20 17:32:14 UTC) #3
xhwang
sandersd: PTAL from media/mojo's perspective, mainly on the folder structure.
4 years, 2 months ago (2016-10-20 17:36:47 UTC) #5
sandersd (OOO until July 31)
On 2016/10/20 17:36:47, xhwang wrote: > sandersd: PTAL from media/mojo's perspective, mainly on the folder ...
4 years, 2 months ago (2016-10-20 18:28:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439813002/20001
4 years, 2 months ago (2016-10-20 18:36:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 20:19:13 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5476624b8b351bfc350ee29ea10a81ad53879134
Cr-Commit-Position: refs/heads/master@{#426579}

Powered by Google App Engine
This is Rietveld 408576698