[Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface.

[Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface.

BUG=616090
Committed: https://crrev.com/f68a448d9ae71c94692ab156a75b85c2d0e301b9
Cr-Commit-Position: refs/heads/master@{#426783}

[Bernhard Bauer, 2016-10-20 14:50:23]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 14:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-10-20 14:58:38]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2016-10-20 14:58:39]

Please review. Thanks!

[Michael van Ouwerkerk, 2016-10-20 15:03:59]

https://codereview.chromium.org/2439763002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java
(right):

https://codereview.chromium.org/2439763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java:44: *
Display the data for this item.
ws?

[commit-bot: I haz the power, 2016-10-20 15:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:35:32]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-20 17:40:27]

https://codereview.chromium.org/2439763002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java
(right):

https://codereview.chromium.org/2439763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java:44: *
Display the data for this item.
On 2016/10/20 15:03:58, Michael van Ouwerkerk wrote:
> ws?

Huh, not sure what happened there. clang-format doesn't seem to modify it
(either this version or the fixed one). Anyway, done.

[dgn, 2016-10-21 10:52:07]

dgn@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[dgn, 2016-10-21 10:52:08]

We were discussing with Michael about some changes related dismissing siblings.

When an item is dismissed, it goes onChildDraw() => onSwipe() => clearView(). We
currently don't call clearView() with the sibling, which might be the cause of a
visual glitch.

Addressing that might involve resolving the sibling differently, so maybe this
code will go away anyway.

I'll leave it up to Michael, since I think he will implement the change.

If you want to land it anyway, it looks good to me :)

https://codereview.chromium.org/2439763002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
(right):

https://codereview.chromium.org/2439763002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java:45:
TreeNode getContainingChildForPosition(int position) {
nit: doc for this please?

It returns the child of the current node that contains the |position|, with
|position| being a global index? Or maybe just name it getChildForPosition? it
would make it more easily paired with getChildIndexForPosition, one returning
the index and the other the item itself

[dgn, 2016-10-21 10:52:22]

lgtm

[Bernhard Bauer, 2016-10-21 12:08:14]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 12:08:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-10-21 12:09:24]

https://codereview.chromium.org/2439763002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
(right):

https://codereview.chromium.org/2439763002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java:45:
TreeNode getContainingChildForPosition(int position) {
On 2016/10/21 10:52:08, dgn wrote:
> nit: doc for this please?
> 
> It returns the child of the current node that contains the |position|, with
> |position| being a global index? Or maybe just name it getChildForPosition? it
> would make it more easily paired with getChildIndexForPosition, one returning
> the index and the other the item itself

Done.

[commit-bot: I haz the power, 2016-10-21 12:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 12:54:51]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-21 13:16:55]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-10-21 13:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org
Link to the patchset: https://codereview.chromium.org/2439763002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2016-10-21 13:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 13:28:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:32:26]

Description was changed from

==========
[Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface.

BUG=616090
==========

to

==========
[Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface.

BUG=616090

Committed: https://crrev.com/f68a448d9ae71c94692ab156a75b85c2d0e301b9
Cr-Commit-Position: refs/heads/master@{#426783}
==========

[commit-bot: I haz the power, 2016-10-21 13:32:27]

Patchset 3 (id:??) landed as
https://crrev.com/f68a448d9ae71c94692ab156a75b85c2d0e301b9
Cr-Commit-Position: refs/heads/master@{#426783}

[Michael van Ouwerkerk, 2016-10-24 13:18:36]

On 2016/10/21 10:52:08, dgn wrote:
> We were discussing with Michael about some changes related dismissing
siblings.
> 
> When an item is dismissed, it goes onChildDraw() => onSwipe() => clearView().
We
> currently don't call clearView() with the sibling, which might be the cause of
a
> visual glitch.
> 
> Addressing that might involve resolving the sibling differently, so maybe this
> code will go away anyway.
> 
> I'll leave it up to Michael, since I think he will implement the change.
> 

I fixed that swipe rendering glitch in
https://codereview.chromium.org/2437923004/

I did it in the rebinding, not in clearView().