Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2439703003: Update tokens for EGL_EXT_image_dma_buf_import_modifiers (Closed)

Created:
4 years, 2 months ago by hshi1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update tokens for EGL_EXT_image_dma_buf_import_modifiers Transition the DMA-BUF import modifier tokens to the officially allocated enum range. To ensure a smooth transition, we need a temporary fallback to the old enum range when the driver rejects the new tokens. We can remove this once chrome successfully uprevs and the corresponding driver updates are made. Extension bug: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16036 BUG=chrome-os-partner:58718 TEST=nyan_big works with both old (2016.07.20) and new (2016.10.13) drivers Committed: https://crrev.com/5b61910ab1bc2bb74e082e20b2ef6ad244cb22e1 Cr-Commit-Position: refs/heads/master@{#426623}

Patch Set 1 #

Patch Set 2 : Forgot to also replace the _HI_EXT tokens #

Total comments: 2

Patch Set 3 : Fix the broken logic - move Initialize outside the for loop and don't return false if the retry suc… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4 lines) Patch
M third_party/khronos/EGL/eglext.h View 2 chunks +17 lines, -0 lines 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap.cc View 1 2 2 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
hshi1
PTAL. kbr, spang: OWNERS hoegsberg, marcheu: FYI
4 years, 2 months ago (2016-10-20 20:38:51 UTC) #2
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2439703003/diff/20001/third_party/khronos/EGL/eglext.h File third_party/khronos/EGL/eglext.h (right): https://codereview.chromium.org/2439703003/diff/20001/third_party/khronos/EGL/eglext.h#newcode589 third_party/khronos/EGL/eglext.h:589: #ifndef EGL_EXT_image_dma_buf_import_modifiers Please coordinate with Khronos to get ...
4 years, 2 months ago (2016-10-20 20:55:09 UTC) #7
hshi1
PTAL Patch Set #3. I just made another local build with the new NV drivers ...
4 years, 2 months ago (2016-10-20 21:18:09 UTC) #8
hshi1
Reviews + rjkroege (OWNERS ui/ozone) Thanks.
4 years, 2 months ago (2016-10-20 21:29:39 UTC) #12
rjkroege
lgtm
4 years, 2 months ago (2016-10-20 21:36:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439703003/40001
4 years, 2 months ago (2016-10-20 22:29:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 22:44:04 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:41 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b61910ab1bc2bb74e082e20b2ef6ad244cb22e1
Cr-Commit-Position: refs/heads/master@{#426623}

Powered by Google App Engine
This is Rietveld 408576698