rebaseline-cl: Don't trigger new try jobs for builders that already have jobs started.

rebaseline-cl: Don't trigger new try jobs for builders that already have jobs started.

In the preliminary CL http://crrev.com/2406153003, I changed Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a dict of Builds (named tuple objects with builder_name and build_number) to result info dicts.

The purpose of this was to make it so that rebaseline-cl could look through the result info dicts to see whether each build is completed or just started, to avoid starting extra builds.

After looking at it some more, I see that in the Rietveld response, builds that are just started but not completed have no build number information.

To avoid having to pass around the result dict information from Rietveld, it's possible to just have a list of Build objects with build_number set to None when the build is just pending or started but not completed.

So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a row, it now prints out:

$ ./webkit-patch rebaseline-cl
 Triggering try jobs for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished.
 $ ./webkit-patch rebaseline-cl
 There are existing pending builds for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished.

And this CL undoes some of the changes made in http://crrev.com/2406153003 in order to simplify the code, because now I think passing full result info dicts is unnecessary.

BUG=654919
Committed: https://crrev.com/9b5bb47fa0a7e219fdaf093a83ba2a1f63f63b7e
Cr-Commit-Position: refs/heads/master@{#426837}

[qyearsley, 2016-10-20 23:46:15]

Description was changed from

==========
Don't trigger new try jobs for builders that already have jobs started.

This CL makes it so that if one runs

See related preliminary CL: http://crrev.com/2406153003

BUG=654919
==========

to

==========
rebaseline-cl: Don't trigger new try jobs for builders that already have jobs
started.

In the preliminary CL http://crrev.com/2406153003, I changed
Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a
dict of Builds (named tuple objects with builder_name and build_number) to
result info dicts.

The purpose of this was to make it so that rebaseline-cl could look through the
result info dicts to see whether each build is completed or just started, to
avoid starting extra builds.

After looking at it some more, I see that in the Rietveld response, builds that
are just started but not completed have no build number information.

To avoid having to pass around the result dict information from Rietveld, it's
possible to just have a list of Build objects with build_number set to None when
the build is just pending or started but not completed.


So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a
row, it now prints out:

$ ./webkit-patch rebaseline-cl
 Triggering try jobs for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.
 $ ./webkit-patch rebaseline-cl
 There are existing pending builds for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.

And this CL undoes some of the changes made in http://crrev.com/2406153003 in
order to simplify the code, because now I think passing full result info dicts
is unnecessary.

BUG=654919
==========

[qyearsley, 2016-10-20 23:46:15]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, wkorman@chromium.org

[Dirk Pranke, 2016-10-21 03:14:00]

lgtm

[qyearsley, 2016-10-21 16:23:03]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:52:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 18:06:54]

Description was changed from

==========
rebaseline-cl: Don't trigger new try jobs for builders that already have jobs
started.

In the preliminary CL http://crrev.com/2406153003, I changed
Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a
dict of Builds (named tuple objects with builder_name and build_number) to
result info dicts.

The purpose of this was to make it so that rebaseline-cl could look through the
result info dicts to see whether each build is completed or just started, to
avoid starting extra builds.

After looking at it some more, I see that in the Rietveld response, builds that
are just started but not completed have no build number information.

To avoid having to pass around the result dict information from Rietveld, it's
possible to just have a list of Build objects with build_number set to None when
the build is just pending or started but not completed.


So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a
row, it now prints out:

$ ./webkit-patch rebaseline-cl
 Triggering try jobs for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.
 $ ./webkit-patch rebaseline-cl
 There are existing pending builds for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.

And this CL undoes some of the changes made in http://crrev.com/2406153003 in
order to simplify the code, because now I think passing full result info dicts
is unnecessary.

BUG=654919
==========

to

==========
rebaseline-cl: Don't trigger new try jobs for builders that already have jobs
started.

In the preliminary CL http://crrev.com/2406153003, I changed
Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a
dict of Builds (named tuple objects with builder_name and build_number) to
result info dicts.

The purpose of this was to make it so that rebaseline-cl could look through the
result info dicts to see whether each build is completed or just started, to
avoid starting extra builds.

After looking at it some more, I see that in the Rietveld response, builds that
are just started but not completed have no build number information.

To avoid having to pass around the result dict information from Rietveld, it's
possible to just have a list of Build objects with build_number set to None when
the build is just pending or started but not completed.

So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a
row, it now prints out:

$ ./webkit-patch rebaseline-cl
 Triggering try jobs for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.
 $ ./webkit-patch rebaseline-cl
 There are existing pending builds for:
   android_blink_rel
   linux_precise_blink_rel
   linux_trusty_blink_rel
   mac10.10_blink_rel
   mac10.11_blink_rel
   mac10.11_retina_blink_rel
   mac10.9_blink_rel
   win10_blink_rel
   win7_blink_rel
 Please re-run webkit-patch rebaseline-cl once all pending try jobs have
finished.

And this CL undoes some of the changes made in http://crrev.com/2406153003 in
order to simplify the code, because now I think passing full result info dicts
is unnecessary.

BUG=654919

Committed: https://crrev.com/9b5bb47fa0a7e219fdaf093a83ba2a1f63f63b7e
Cr-Commit-Position: refs/heads/master@{#426837}
==========

[commit-bot: I haz the power, 2016-10-21 18:06:57]

Patchset 2 (id:??) landed as
https://crrev.com/9b5bb47fa0a7e219fdaf093a83ba2a1f63f63b7e
Cr-Commit-Position: refs/heads/master@{#426837}